src/web/pages/flow.ts drops the unused live and readQueues imports #39

Merged

grokbot merged 2 commits from grokbot/forge:fix/2171-flow-unused-imports into main

2026-10-17 20:00:51 +00:00

grokbot commented

2026-10-17 17:34:08 +00:00

Owner

Closes forge tracker issue #2171 (https://forge-trevato-apps.open-platform.sh/trevato/forge/issues/2171). Pillar (2) Cut the noise.

After #2139 the flow page reads duplicates through systemFor and the queue through queuesFor, so live (from system/live.ts) and the value readQueues (from flow/queue.ts) were imported and never used. tsc doesn't flag them because noUnusedLocals is off. This drops the live import and keeps only import type { QueueRow }. Both modules still load through system/telemetry.ts, so nothing changes at import time. No behaviour change.

Tests:

bun scripts/gate.ts: exit 0
./node_modules/typescript/bin/tsc --noEmit: clean
bun test --timeout 60000 on flow-pipeline, flow-throughput, flow-stage, flow-card, merge-queue, crew-held, system-telemetry and check-list: 79 pass, 0 fail across 8 files

The full gate wasn't run locally.

Closes forge tracker issue #2171 (https://forge-trevato-apps.open-platform.sh/trevato/forge/issues/2171). Pillar (2) Cut the noise. After #2139 the flow page reads duplicates through `systemFor` and the queue through `queuesFor`, so `live` (from `system/live.ts`) and the value `readQueues` (from `flow/queue.ts`) were imported and never used. tsc doesn't flag them because `noUnusedLocals` is off. This drops the `live` import and keeps only `import type { QueueRow }`. Both modules still load through `system/telemetry.ts`, so nothing changes at import time. No behaviour change. Tests: - `bun scripts/gate.ts`: exit 0 - `./node_modules/typescript/bin/tsc --noEmit`: clean - `bun test --timeout 60000` on flow-pipeline, flow-throughput, flow-stage, flow-card, merge-queue, crew-held, system-telemetry and check-list: 79 pass, 0 fail across 8 files The full gate wasn't run locally.

grokbot added 1 commit

2026-10-17 17:34:08 +00:00

src/web/pages/flow.ts drops the unused live and readQueues imports (#2171 )

preview / preview (pull_request) Failing after 2s

Details

check / gate (1) (pull_request) Failing after 14s

Details

check / gate (3) (pull_request) Failing after 13s

Details

check / gate (2) (pull_request) Failing after 16s

Details

check / check (pull_request) Failing after 1s

Details

cf8de4df0d

After #2139 the flow page reads duplicates through systemFor and the
queue through queuesFor, so the live import from system/live.ts and the
readQueues value from flow/queue.ts were unused; tsc does not flag them
because noUnusedLocals is off. Only the QueueRow type is kept, as an
import type. Both modules still load through system/telemetry.ts, so
nothing at import time changes.

grokbot referenced this pull request

2026-10-17 18:04:55 +00:00

A pull from a fork gets its check: the gate fetches refs/pull/<n>/head when the head is not on a branch, and the preview skips forks #40

grokbot referenced this pull request from a commit

2026-10-17 19:28:17 +00:00

A pull from a fork gets its check: the gate fetches refs/pull/<n>/head when the head is not on a branch, and the preview skips forks

grokbot added 1 commit

2026-10-17 19:28:29 +00:00

Merge branch 'main' into fix/2171-flow-unused-imports

check / gate (2) (pull_request) Successful in 3m23s

Details

check / gate (3) (pull_request) Successful in 4m10s