The ceiling-reserve test's account says its origin, so main type-checks again now that createUser takes one #54

Merged
grokbot merged 1 commit from grokbot/forge:fix/ceiling-reserve-origin into main 2026-10-17 22:14:20 +00:00
Owner

#52 (dev/ceiling-reserve) was written before #43 made createUser's origin required, and both merged, so test/account-ceiling-reserve.test.ts:46 failed tsc on main 006d3977 (TS2345: property 'origin' is missing). The fixture uses seed, the origin for test fixtures, as every other test does.

Validation

pipeline/validate on b9c2abf2: pass in 27s — bun 1.3.14, CI-shaped env (scrubbed vars, runner PATH), exact check.yml shard + forge.json commands.

step result time
bun install --frozen-lockfile ok (exit 0) 0s
forge.json check.fast ok (exit 0) 13s
check.yml gate (1) pull_request ok (exit 0) 11s
check.yml gate (2) pull_request ok (exit 0) 1s
check.yml gate (3) pull_request ok (exit 0) 2s
  • ⚠️ node v20.19.2 here, v22 on CI (tsc runs under node)
test output (failures, totals)
▶ bun install --frozen-lockfile
  ok  exit 0  0s
▶ forge.json check.fast
Ran 88 tests across 8 files in 10.6s (8 shards).
  ok  exit 0  13s
▶ check.yml gate (1) pull_request
Ran 6 tests across 2 files in 10.9s (2 shards).
  ok  exit 0  11s
▶ check.yml gate (2) pull_request
Ran 14 tests across 3 files in 0.1s (3 shards).
  ok  exit 0  1s
▶ check.yml gate (3) pull_request
Ran 68 tests across 3 files in 2.3s (3 shards).
  ok  exit 0  2s
#52 (dev/ceiling-reserve) was written before #43 made createUser's origin required, and both merged, so test/account-ceiling-reserve.test.ts:46 failed tsc on main 006d3977 (TS2345: property 'origin' is missing). The fixture uses `seed`, the origin for test fixtures, as every other test does. <!-- pipeline:validation --> ### Validation `pipeline/validate` on `b9c2abf2`: **pass** in 27s — bun 1.3.14, CI-shaped env (scrubbed vars, runner PATH), exact check.yml shard + forge.json commands. | step | result | time | |---|---|---| | `bun install --frozen-lockfile` | ok (exit 0) | 0s | | `forge.json check.fast` | ok (exit 0) | 13s | | `check.yml gate (1) pull_request` | ok (exit 0) | 11s | | `check.yml gate (2) pull_request` | ok (exit 0) | 1s | | `check.yml gate (3) pull_request` | ok (exit 0) | 2s | - ⚠️ node v20.19.2 here, v22 on CI (tsc runs under node) <details><summary>test output (failures, totals)</summary> ``` ▶ bun install --frozen-lockfile ok exit 0 0s ▶ forge.json check.fast Ran 88 tests across 8 files in 10.6s (8 shards). ok exit 0 13s ▶ check.yml gate (1) pull_request Ran 6 tests across 2 files in 10.9s (2 shards). ok exit 0 11s ▶ check.yml gate (2) pull_request Ran 14 tests across 3 files in 0.1s (3 shards). ok exit 0 1s ▶ check.yml gate (3) pull_request Ran 68 tests across 3 files in 2.3s (3 shards). ok exit 0 2s ``` </details>
The ceiling-reserve test's account says its origin, so main type-checks again now that createUser takes one
All checks were successful
check / gate (1) (pull_request) Successful in 29s
check / gate (2) (pull_request) Successful in 16s
check / gate (3) (pull_request) Successful in 16s
check / check (pull_request) Successful in 0s
preview / preview (pull_request) Has been skipped
b9c2abf292
#52 (dev/ceiling-reserve) was written before #43 made createUser's origin required, and both merged, so test/account-ceiling-reserve.test.ts:46 failed tsc on main 006d3977 (TS2345: property 'origin' is missing). The fixture uses `seed`, the origin for test fixtures, as every other test does.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
trevato-apps/forge!54
No description provided.